25 replies to this topic

[AlexDeath]

Hey give me please fix 2 pyroblast. Thank's.

[NoHad]

It is problem only in spell_linked_spell make this + Pyroblast Aura = - Presence of Mind

[Lovelol]

Give pyroblast a 0,1 sec gcd

[NoHad]

Ye and this is other solution

[Trentone]

Lovelol, pyroblast already have gcd of 1.5 sec. It's not gcd fault.
Nohad, pyroblast doesn't apply any aura to a caster.

[NoHad]

I Think Spell id of + pyroblast when casted = - presence of mind it is only in spell_linked_spell

[Lovelol]

Ofc it is a GCD issue, because when you call the gcd like this

uint32 cdTime = spellInfo->StartRecoveryTime;

 
if (m_spellInfo->Id == PYROBLAST) cdTime = 1500;

this bug is gone.

[Trentone]

Lovelol, Pyroblast ALREADY have globalcooldown. Your fix will not do anything, and btw it's not gcd issue. You can cast 2 instant pyros from 40 yds even with gcd.

11366,0,0,0,0,0x10000,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0,0,1,0,0,0,0x0,171,0,0,15,0,0,0x0,101,0,24,20,20,29,0,125,0,0,,35,24.0,0,0,0,,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0x0,0,-1,0,0x0,2,6,0,47,1,0,1,0x1,0,0,,,1.89999997616,0.0,0.0,140,13,0,0,0,0,6,6,0,0,0,0,0,0,0,0,3,0,0,3000,0,0.0,0.0,0.0,0,0,0x0,0,0,0,0,0,0,0,0,0,0,0,0,0.0,,,2253,0,184,0,0x32,"Pyroblast",,,,,,,,,,,,,,,,16712190,"Rank 1",,,,,,,,,,,,,,,,0xFF01FE,"Hurls an immense fiery boulder that causes $s1 Fire damage and an additional $o2 Fire damage over $d.",,,,,,,,,,,,,,,,0xFF01FE,"$s2 Fire damage every $t2 seconds.",,,,,,,,,,,,,,,,0xFF01FE,0,0x85,1500,0,3,0x400000,0x0,0,1,0x1,0,1.0,1.0,1.0,,,0x0,0,0,0,0x4,

NoHad, it's not only Presense of Mind. It's Nature's Swiftness too. Shamans and Druids have the same bug. And there's not only pyroblast which is flying spell, so player will cast first fireball and then pyroblast, if it will be removed only at pyroblast cast. Same for other classes.

[Daron]

NoHad, on 18 August 2011 - 04:38 PM, said:

I Think Spell id of + pyroblast when casted = - presence of mind it is only in spell_linked_spell

This can work but you have to do this for all spells that would consume presence of mind. Problem is that Spell Procs are handled in DoAllEffectsOnTarget. Due to the fact that the casts a mage have are flying spells, DoAllEffectsOnTarget is handeld delayed and also Presence of Mind or Nature's Swiftniss is removed delayed. So on one hand you can rewrite proc system, because some procs should be handeld on spell go and others on spell hit or you just implement something that removes Nature's Swiftniss and Presence of Mind in cast function for the right spells (think this would be a little bit hacky :D)

[omgwtfzomg]

How do you replicate this bug?

[Trek]

Please use english.

[desteny]

the problem is not the gcd or something else, (could fix it or not, i never tryed)

but fact is, the bug is a aura update issue:

let me give you a example:

use macro for Presence of Mind + pyro + pyro + ... it will affect the bug.

whats the problem in detail:

Presence of Mind makes pyro instant, and triggers the remove of the aura, but this will happen on the next update cycle and meanwhile there will executed an other pyro (instant, because the server thinks the aura of "Presence of Mind " is active.

for this reason i think gcd will not solve the problem because the "Presence of Mind" skipps the gcd.

one posibility to solve the problem is forcing the aura update, or change the order of the update cycles (im not even shure if this will help)
but both solutions are a lot of work.

you could write a simple hackfix, by using a new timer variable in unit or player and check it before pyro, and skip it if 0.2m (or something like this) milliseconds are passed.

BUT very hacky and no solution for the main repo!!!

[omgwtfzomg]

I can't seem to reproduce this bug on my server so I assume it is fixed. I had changed the gcd system on my server so it might be gcd.

[Trentone]

I can cast 2 instant pyros even with 1.5 sec gcd waiting. Just stay far away from target and you'll get your "cookie".

[Lovelol]

Well, I also can't confirm this.

[desteny]

oh, .. .other theory, Presence of Mind will be removed when the pyro hits the target and not when the pyro starts.
probably simple fix, (hackfix) remove aura when pyro is casted.

gcd doesnt affect because Presence of Mind skipps gcd (i dont know if this is also a bug)

you could check it this way:
cast a pyro (normal)
use normal pyro macro.

you will see the macro pyro comes without gcd right after clicking

[Lovelol]

Well, I really can't reproduce this.

I'm using this macro: /cast PoM /cast Pyro /cast Pyro

I get PoM Aura and cast a pyroblast instant, the pyro is still flying and I still got the PoM Aura up. I can another pyroblast while the first one is still flying and I still got the PoM aura up. This second pyroblast is a normal cast, not instant. As I said it is working like it should for me.

[omgwtfzomg]

I can't reproduce it on my server (like I said I've changed the GCD system abit) and I've done what you guys have said.

[Daron]

I didn't changed anything related to this on the spell system and can't reproduce this bug neither.

[Lovelol]

Well this is how it looks like on my server.